[CIUv3] Custom Installer Ultimate v3

[K4miKaZe]

So i might have found a long standing bug (or maybe im just too dumb to make it work xD). It's about the [CustomIniFile] section. To make it simple, i've used a copy paste from the CIU Documentation to test it out and the Value entry never got applied to the .ini file, it always put into Value the path and .ini name instead.

Setup.ini:

{app}\IniFile3.ini; Section: Settings; Key: Language; Create: 1; Value: EN=english|ES=Spanish|FR=French|DE=German

After installation the IniFile3.ini is created, the section also is created inside the .ini and the Key also works too. But the Value returns the path instead of the value.

IniFile3.ini created by CIU after install:

[Settings]
Language={app}\IniFile3.ini

I've tried out a few diff ways on the .ini but none worked, so i took a look into the .iss file and found this:

          begin
            if FileExists(IniName) or (StrToIntDef(LineDecode(TmpStr, 'Create', '0'), 0) = 1) then
            begin
              IniValue := LineDecode(TmpStr, '', '');

And changed it to this:

IniValue := LineDecode(TmpStr, 'Value', '');

On the setup.ini now its working fine, just needs to remove the spacing between Value: and the value, like this:

{app}\IniFile3.ini; Section: Settings; Key: Language; Create: 1; Value:EN=english|ES=Spanish|FR=French|DE=German

Not sure if this was intended on the .iss and i'm just using a wrong string on the setup.ini. I just leave it here if you want to take a look into it.

Regards !!!

[Cesar82]

Originally Posted by K4miKaZe

So i might have found a long standing bug (or maybe im just too dumb to make it work xD). It's about the [CustomIniFile] section. To make it simple, i've used a copy paste from the CIU Documentation to test it out and the Value entry never got applied to the .ini file, it always put into Value the path and .ini name instead.

Setup.ini:

{app}\IniFile3.ini; Section: Settings; Key: Language; Create: 1; Value: EN=english|ES=Spanish|FR=French|DE=German

After installation the IniFile3.ini is created, the section also is created inside the .ini and the Key also works too. But the Value returns the path instead of the value.

IniFile3.ini created by CIU after install:

[Settings]
Language={app}\IniFile3.ini

I've tried out a few diff ways on the .ini but none worked, so i took a look into the .iss file and found this:

          begin
            if FileExists(IniName) or (StrToIntDef(LineDecode(TmpStr, 'Create', '0'), 0) = 1) then
            begin
              IniValue := LineDecode(TmpStr, '', '');

And changed it to this:

IniValue := LineDecode(TmpStr, 'Value', '');

On the setup.ini now its working fine, just needs to remove the spacing between Value: and the value, like this:

{app}\IniFile3.ini; Section: Settings; Key: Language; Create: 1; Value:EN=english|ES=Spanish|FR=French|DE=German

Not sure if this was intended on the .iss and i'm just using a wrong string on the setup.ini. I just leave it here if you want to take a look into it.

Regards !!!

Thank you for the informations.

It really is wrong and the solution is the same.
Maybe including something to remove the first space in the value if it exists would be interesting.

[K4miKaZe]

Originally Posted by Cesar82

Thank you for the informations.

It really is wrong and the solution is the same.
Maybe including something to remove the first space in the value if it exists would be interesting.

Yeah, that should be easy now, i just leaved it that way because i was too tired yesterday to keep looking. Will take a look in a few and update this message with the full code change. I'm still testing out the new CIU, lot of things have changed since 2020.

Thank's to you for keeping this up !!!

EDIT:

So seems like adding Trim to the LineDecode was enough to fix the spacing issue. I've done some tests and all went fine. 1st test was to just let CIU make a clean .ini with the language feature, second test was letting CIU modify an existent .ini to replace the value with the language feature and another test to add custom values without the language feature. All went fine. So here is the original code on the latest beta hf2 (from december) and the only little change i made to it.

Original:

          begin
            if FileExists(IniName) or (StrToIntDef(LineDecode(TmpStr, 'Create', '0'), 0) = 1) then
            begin
              IniValue := LineDecode(TmpStr, '', '');
              if (IniValue = '') or ((Pos('=', IniValue) > 0) and (Pos('|', IniValue) > 0) and (Pos(LowerCase(ActLangShort + '='), LowerCase(IniValue)) = 0)) then

Modified (marked in red):

          begin
            if FileExists(IniName) or (StrToIntDef(LineDecode(TmpStr, 'Create', '0'), 0) = 1) then
            begin
              IniValue := Trim(LineDecode(TmpStr, 'Value', ''));
              if (IniValue = '') or ((Pos('=', IniValue) > 0) and (Pos('|', IniValue) > 0) and (Pos(LowerCase(ActLangShort + '='), LowerCase(IniValue)) = 0)) then