ISArcEx - A FreeArc Archive Extractor Plugin for InnoSetup

[BLACKFIRE69]

Originally Posted by BLACKFIRE69

ok, i'll let you change the output directory when adding disks.

 <--- Change --->

1. syntax:

   function ISArcExAddDisks(Inputfile, Password, OutputPath: Widestring): boolean;

   function ISArcExExtract(DiskNumber: Integer; CfgFile, WorkPath: Widestring): boolean;


2. example:

// Disk Adding part
repeat
  if FileExists(ExpandConstant('{src}\data1.bf')) then 
  begin
    ISArcDiskAddingFalied:= ISArcExAddDisks(ExpandConstant('{src}\data1.bf'), 
               '{#DiskPassword}', ExpandConstant('{app}'));

    if ISArcDiskAddingFalied then break;
    ISArcExDiskCount := ISArcExDiskCount + 1;
  end;

  ...

  #ifdef Components
  if IsComponentSelected('something1\something2') then 
  begin
    ISArcDiskAddingFalied:= ISArcExAddDisks(ExpandConstant('{src}\ConfigShit.bf'), 
               '{#DiskPassword}', ExpandConstant('{userdocs}\BFGames'));

    if ISArcDiskAddingFalied then break;
    ISArcExDiskCount := ISArcExDiskCount + 1;
  end;

  ...

  #endif
until true;


.....
  // Extraction
   
  for i := 1 to ISArcExDiskCount do 
  begin
    ISArcExError := not ISArcExExtract(i, ExpandConstant('{tmp}\arc.ini'), ExpandConstant('{app}\temp'));
    if ISArcExError then break;
  end;
.....

summary:

  data1.bf       --->    {app}
  ...
  configShit.bf  --->    {userdocs}\BFGames}
  ...

Note: just replacing the library (.dll) is not enough. update your previous scripts as well.


.

guys, can you tell me is this lib detected as a virus?

[BLACKFIRE69]

VER: 0.4.0.1

What's new:

 - Improved performance, percentage and times.


( this version is not compatible with the old version (v.0.4) )

[ffmla]

Originally Posted by BLACKFIRE69

guys, can you tell me is this lib detected as a virus?

My K7 AV didn't detect anything..
VirusTotal report the following things.

[Masquerade]

I've tried updating my script to reflect the new changes however now for some reason the error flag will instantly trigger leading to a failed installation.

There is no log written or IsArcEx error message box that could indicate the problem.

Please may you take a look at my changes and see if anything is incorrect? The old strings are commented out with //.

Thank you!

//function ISArcExAddDisks(Inputfile, Password: Widestring): boolean;
function ISArcExAddDisks(Inputfile, Password, OutputPath: Widestring): boolean;
  external 'ISArcExAddDisks@files:ISArcEx.dll stdcall';
//function ISArcExExtract(DiskNumber: Integer; OutputPath, CfgFile, WorkPath: Widestring): boolean;
function ISArcExExtract(DiskNumber: Integer; CfgFile, WorkPath: Widestring): boolean;
  external 'ISArcExExtract@files:ISArcEx.dll stdcall';

    #ifdef Data1
      if FileExists(ExpandConstant('{src}\{#Data1}')) then
      begin
        ISArcDiskAddingFalied:= ISArcExAddDisks(ExpandConstant('{src}\{#Data1}'), '{#DiskPassword}', ExpandConstant('{app}'));
        if ISArcDiskAddingFalied then break;
        ISArcExDiskCount:= ISArcExDiskCount + 1;
      end;
    #endif

for i:= 1 to ISArcExDiskCount do
        begin
          //ISArcExError := not ISArcExExtract(i, ExpandConstant('{app}\'), ExpandConstant('{tmp}\ARC.INI'), ExpandConstant('{app}'));
          ISArcExError := not ISArcExExtract(i, ExpandConstant('{tmp}\ARC.INI'), ExpandConstant('{app}'));
          if ISArcExError then break;
        end;

[BLACKFIRE69]

Originally Posted by Masquerade

I've tried updating my script to reflect the new changes however now for some reason the error flag will instantly trigger leading to a failed installation.

There is no log written or IsArcEx error message box that could indicate the problem.

Please may you take a look at my changes and see if anything is incorrect? The old strings are commented out with //.

Thank you!

//function ISArcExAddDisks(Inputfile, Password: Widestring): boolean;
function ISArcExAddDisks(Inputfile, Password, OutputPath: Widestring): boolean;
  external 'ISArcExAddDisks@files:ISArcEx.dll stdcall';
//function ISArcExExtract(DiskNumber: Integer; OutputPath, CfgFile, WorkPath: Widestring): boolean;
function ISArcExExtract(DiskNumber: Integer; CfgFile, WorkPath: Widestring): boolean;
  external 'ISArcExExtract@files:ISArcEx.dll stdcall';

    #ifdef Data1
      if FileExists(ExpandConstant('{src}\{#Data1}')) then
      begin
        ISArcDiskAddingFalied:= ISArcExAddDisks(ExpandConstant('{src}\{#Data1}'), '{#DiskPassword}', ExpandConstant('{app}'));
        if ISArcDiskAddingFalied then break;
        ISArcExDiskCount:= ISArcExDiskCount + 1;
      end;
    #endif

for i:= 1 to ISArcExDiskCount do
        begin
          //ISArcExError := not ISArcExExtract(i, ExpandConstant('{app}\'), ExpandConstant('{tmp}\ARC.INI'), ExpandConstant('{app}'));
          ISArcExError := not ISArcExExtract(i, ExpandConstant('{tmp}\ARC.INI'), ExpandConstant('{app}'));
          if ISArcExError then break;
        end;

yes, there's something incorrect. see the hint below.

v0.4.0.0 (Old)  >>  ISArcDiskAddingFalied

v0.4.0.1 (New)  >>  ISArcDiskAddingSuccess

let me know if you need more help.

Originally Posted by Masquerade

There is no log written or IsArcEx error message box that could indicate the problem.

add this before the ISArcExInit. you'll see the error. (sorry, i put the error message in the wrong place in the script)

if ISArcExDiskCount = 0 then
   MsgBox('There is no any archive found for unpacking.', mbError, MB_OK);

[Masquerade]

Originally Posted by BLACKFIRE69

yes, there's something incorrect. see the hint below.

v0.4.0.0 (Old)  >>  ISArcDiskAddingFalied

v0.4.0.1 (New)  >>  ISArcDiskAddingSuccess

Maybe I am not following, but I don't see how changing the name of the Boolean for the disk adding command will fix the issue.

[BLACKFIRE69]

Originally Posted by Masquerade

Maybe I am not following, but I don't see how changing the name of the Boolean for the disk adding command will fix the issue.

i know it's a bit confusing. but note that it's not just changing the variable name, the ISArcExAddDisks function has also changed.


1).
in the previous version (v0.4) ISArcExAddDisks function returns error state when adding the disks.

i.e. it returns true if a disk was added unsuccessfully (failed). so you need to catch the error state.

ISArcDiskAddingFalied:= ISArcExAddDisks(...);
if ISArcDiskAddingFalied then break;

2).
the new version (v0.4.0.1) returns the success of adding disks.

i.e. it returns true if a disk was added successfully.

ISArcDiskAddingSuccess:= ISArcExAddDisks(...);
if not ISArcDiskAddingSuccess then break;

3).
this is the summarized difference.

v0.4
procedure CurStepChanged(CurStep: TSetupStep);
begin
   ...
   ISArcDiskAddingFalied := True;
   ...
   repeat
      if FileExists(...) then 
      begin
        ISArcDiskAddingFalied:= ISArcExAddDisks(...);
        if ISArcDiskAddingFalied then break;
        ISArcExDiskCount := ISArcExDiskCount + 1;
      end;
      ...
   until true;
 
   if (not ISArcDiskAddingFalied) and ISArcExInit(...) then
   begin
    ...
   end;
end;

v0.4.0.1
procedure CurStepChanged(CurStep: TSetupStep);
begin
   ...
   ISArcDiskAddingSuccess := False;
   ...
   repeat
      if FileExists(...) then 
      begin
        ISArcDiskAddingSuccess:= ISArcExAddDisks(...);
        if not ISArcDiskAddingSuccess then break;
        ISArcExDiskCount := ISArcExDiskCount + 1;
      end;
      ...
   until true;
  
   if (ISArcDiskAddingSuccess) and ISArcExInit(...) then
   begin
    ...
   end;
end;

[Masquerade]

@BLACKFIRE69

Thank you for the expansion of your little hint (steps 1 and 2) it was more than sufficient to help me understand the logic behind the instructions. Thanks again and apologies.