INNO TROUBLESHOOT - Questions Here

[Masquerade]

Hello all, I have been adding the module ITDownload to my installer script, so redist files can be downloaded instead of me having to bundle them into the installer.

I currently have everything integrated, here is an example:

procedure InstallRedists;
  begin
  itd_init;
  #ifdef directx
  itd_addfile('https://download.microsoft.com/download/1/7/1/1718CCC4-6315-4D8E-9543-8E28A4E18C4C/dxwebsetup.exe',expandconstant('{app}\_Redist\dxwebsetup.exe'));
  #endif

  itd_downloadafter(wpInstalling);

  #ifdef directx
  Exec2(ExpandConstant('{app}\_Redist\dxwebsetup.exe'),'',true);
  #endif 
end;

At the start of the script,

#define directx

exists so this code does apply.

I integrated into the script the iss file and module:

#include "Resources\Modules\itd\it_download.iss"

However now when compiling, this error appears:



Does anyone know what this error could mean? The error lies in the iss script for the ITDownlaod module and not in my installer script.

I am using Inno Setup Unicode 6.0.3

[pincoball]

Seems like the variable type PChar is not anymore compatible with Inno Setup 6.
https://jrsoftware.org/ishelp/index.php?topic=unicode

Quoting:

Its 'PChar' type has been renamed to 'PAnsiChar'

and

If you want to compile an existing script that imports ANSI Windows API calls with the Unicode compiler, either upgrade to the 'W' Unicode API call or change the parameters from 'String' or 'PChar' to 'AnsiString'. The 'AnsiString' approach will make your [Code] compatible with both the Unicode and the non Unicode version.

Try replacing in the mentioned script from PChar to either PAnsiChar or AnsiString

[Masquerade]

Originally Posted by pincoball

Try replacing in the mentioned script from PChar to either PAnsiChar or AnsiString

Compiling works, brilliant!

On testing though, things get a little nasty:



The progress bar is at 100% so the redist downloader process is began.

Installing/Uninstalling works without checking redist box so the script still functions. Only with redist selected will cause this.

Edit: the module is loaded, behind the buttons that the text for the module is there (the progress bar, eta etc..).

[pincoball]

I think that this module is pretty old and it might not support newer versions of Inno Setup thus the problem may arise from another incompatibility... but I think that something else can be done.
Have you tried translating the error message? I know that if you cannot copy and paste you should rely on OCR reading from the screenshot but I think you might give it a try if it says something relevant

Also, does it give the same problem with both PAnsiChar and AnsiString?

[Cesar82]

Originally Posted by Masquerade

Compiling works, brilliant!

On testing though, things get a little nasty:



The progress bar is at 100% so the redist downloader process is began.

Installing/Uninstalling works without checking redist box so the script still functions. Only with redist selected will cause this.

Edit: the module is loaded, behind the buttons that the text for the module is there (the progress bar, eta etc..).

Can you send me the code that is showing this image message?
I would like to analyze this.

Another way to make Unicode and Ansi compatible is to just include this before the functions that PChar uses.

#ifdef UNICODE
type
  PChar = PAnsiChar;
#endif

I found it much more interesting to download this module DwinsHs.
The FTP, HTTP and HTTPS protocols are supported.

[Masquerade]

Originally Posted by Cesar82

I found it much more interesting to download this module DwinsHs.
The FTP, HTTP and HTTPS protocols are supported.

Thank you Cesar, I will try and implement this. Is there a way to add an extra page to the installer after installing for the redist downloading? I am using the ASIS script which already has an extra page for CRC checking.

[KaktoR]

Originally Posted by Masquerade

Thank you Cesar, I will try and implement this. Is there a way to add an extra page to the installer after installing for the redist downloading? I am using the ASIS script which already has an extra page for CRC checking.

Sure. Just create a new page

Look on how the CRCPage was created. This should guide you in the right direction

[bunti_o4u]

I am trying to load the items in a combobox from a text file but whats it loading is the last line and not all the lines..

Pl help. Thnx in advance..

var
  S: String;

function GetFileLines(const FileName: string; out Items: string): Boolean;
var
  FileLines: TArrayOfString;
  LineIndex: Integer;
begin
  Result:= LoadStringsFromFile(FileName, FileLines);
  if Result then
    for LineIndex:=0 to (GetArrayLength(FileLines)-1) do
    Items:= FileLines[LineIndex];
end;

  Combobox1:= TComboBox.Create(WizardForm);
  with Combobox1 do
  begin
    Parent:=WizardForm;
    SetBounds(left, Top, Width, Height);
    Style:=csDropDown;
    Color:=clWhite;
    if GetFileLines(ExpandConstant('{src}\Text.ini'), S) then
      Items.Add(S);
  end;

[Cesar82]

Originally Posted by bunti_o4u

I am trying to load the items in a combobox from a text file but whats it loading is the last line and not all the lines..

Pl help. Thnx in advance..

var
  S: String;

function GetFileLines(const FileName: string; out Items: string): Boolean;
var
  FileLines: TArrayOfString;
  LineIndex: Integer;
begin
  Result:= LoadStringsFromFile(FileName, FileLines);
  if Result then
    for LineIndex:=0 to (GetArrayLength(FileLines)-1) do
    Items:= FileLines[LineIndex];
end;

  Combobox1:= TComboBox.Create(WizardForm);
  with Combobox1 do
  begin
    Parent:=WizardForm;
    SetBounds(left, Top, Width, Height);
    Style:=csDropDown;
    Color:=clWhite;
    if GetFileLines(ExpandConstant('{src}\Text.ini'), S) then
      Items.Add(S);
  end;

TRY:

procedure GetFileLines(const FileName: string; var Combo: TComboBox);
var
  FileLines: TArrayOfString;
  LineIndex: Integer;
begin
  if  LoadStringsFromFile(FileName, FileLines) then
    for LineIndex := 0 to GetArrayLength(FileLines) - 1 do
      Combo.Items.Add(FileLines[LineIndex]);
end;

  Combobox1:= TComboBox.Create(WizardForm);
  with Combobox1 do
  begin
    Parent := WizardForm;
    SetBounds(left, Top, Width, Height);
    Style := csDropDown;
    Color := clWhite;
    GetFileLines(ExpandConstant('{src}\Text.ini'), Combobox1)
  end;