ASIS: Advanced Simple Installer Script

[KaktoR]

Try this

[insertdisc]

Originally Posted by KaktoR

Try this

Line 4492:
Column 7:
Unknown identifier 'DSG_FinishUninstallFilesList'

It errors out during compile.

[KaktoR]

Works fine here. Did you changed something in DSG_Module.iss?

[insertdisc]

Originally Posted by KaktoR

Works fine here. Did you changed something in DSG_Module.iss?

Negative. I just tried with a Vanilla v7.5.0 and the fix script and 2 different extracted setup.DLL files. Same error.

[insertdisc]

Originally Posted by KaktoR

Works fine here. Did you changed something in DSG_Module.iss?

I got the script to compile. I had forgotten the hotfix with the module in it. I'll test the CRC fix ASAP. Thanks for your help so far.

Edit: Everything seems to be working as intended! Thank you!

[insertdisc]

Found a typo. Just thought you should know.

"Your system does partially meet the hardware reuirements."

[insertdisc]

Is there a way to scale the title bar height and left padding with DPI changes as well? Things start getting clipped/overlapped at uhd resolutions and over %200 scale. I can edit the height in a fixed way by editing the vsf but I'm sure that will be huge on lower resolutions. Am I walking into a dead end here?

[PHM2D]

I think I found a bug for the components page when using compact mode (Hotfix 8).
This bug makes the Start Menu Checkbox stay visible on components page when using compact mode.


FIX:

in this section:

ComponentsPageVisible := (not ComponentsPageVisible);

we should add

StartMenuCB.Visible

under the

#if !UpdateMode

as well so it would look like this:

      #if !UpdateMode
        IconsCB.Visible := (not ComponentsPageVisible);
        StartMenuCB.Visible := (not ComponentsPageVisible);
        UnInstallCB.Visible := (not ComponentsPageVisible);
      #endif

the same should be done for the tasks' page.

[KaktoR]

Thanks, fixed.

The same should be added on

procedure TasksPageClick(Sender: TObject);

StartMenuCB.Visible := (not TasksPageVisible);

[trillestdwane]

Is there anyway to modify the script to have a separate audio file play during the splash screen, and then start the normal music file when the splash ends? I tried using a LLM to analyze the script and Settings.ini to see if it could add that in, and it couldn't. Not really an important feature, but I was just wondering

[PHM2D]

When I checked the start menu shortcut creator checkbox, I realized that the shortcut is not created inside the programs folder of the start menu. However it was created when I checked the desktop shortcut creator checkbox. So I fixed it like this:

//#if !CompactMode || !UpdateMode
//  function CreateIconsDesktop: Boolean;
//  begin
//    Result := (not IsDoneError) and IconsCB.Checked;
//  end;

//  function IsUninstallable: Boolean;
//  begin
//    Result := UninstallCB.Checked;
//  end;
//#endif

//#if !CompactMode
//function CreateIconsStartMenu: Boolean;
//begin
//  Result := (not IsDoneError) and (not StartMenuCB.Checked);
//end;
//#endif

function CreateIconsDesktop: Boolean;
begin
  Result := (not IsDoneError) and Assigned(IconsCB) and IconsCB.Checked;  // your “desktop shortcut” checkbox
end;

function CreateIconsStartMenu: Boolean;
begin
  Result := (not IsDoneError) and Assigned(StartMenuCB) and StartMenuCB.Checked;
end;

function IsUninstallable: Boolean;
begin
  Result := Assigned(UninstallCB) and UninstallCB.Checked;
end;

procedure StartMenuCBClick(Sender: TObject);
var
  CB: TNewCheckBox;
begin
  if (Sender is TNewCheckBox) then CB := TNewCheckBox(Sender) else CB := StartMenuCB;
  if Assigned(WizardForm) and Assigned(CB) then
  begin
    WizardForm.GroupEdit.Enabled := CB.Checked;
    WizardForm.GroupBrowseButton.Enabled := CB.Checked;
  end;
end;

Then called it inside the

StartMenuCB := TNewCheckBox.Create(WizardForm);

like this:

      Checked  := False;             // 1) set default state
      OnClick  := @StartMenuCBClick; // 2) wire the handler
      StartMenuCBClick(StartMenuCB); // 3) Synchronize the UI to the current checkbox state
    end;

I don't know if anyone has experienced this bug but here is my solution nevertheless!

[KaktoR]

Thanks, there is another bug when you create icons. If you use uninstaller the icons from startmenu will not get removed. I already fixed it here.

However Icon creation should not be possible when using UpdateMode, so all you have to do is change

#if !CompactMode || !UpdateMode

to

#if !UpdateMode

on line 1077 and 4572.

Edit: Should be fixed now. Use attachment and look for code changes.

[Razer-785]

Hello can you please update the installer to work with DiskSpan_GUI v2.0.2.4 Thanks.

[KaktoR]

I need someone for testing dpi scaling with native 4k resolution.

What you should test: change desktop dpi scaling from 100% to 200% (or higher if possible) and see if all elements are on the correct place.

This test should be really quick. Just run the installer and click through every page.

[KaktoR]

Here is the new 7.6.0 update, currently in beta.

If you find any errors, let me know.