View Single Post
  #19  
Old 05-01-2023, 13:27
BLACKFIRE69's Avatar
BLACKFIRE69 BLACKFIRE69 is offline
Registered User
 
Join Date: Mar 2019
Location: In the Hell
Posts: 688
Thanks: 481
Thanked 2,547 Times in 561 Posts
BLACKFIRE69 is on a distinguished road
Quote:
Originally Posted by Masquerade View Post
I've tried updating my script to reflect the new changes however now for some reason the error flag will instantly trigger leading to a failed installation.

There is no log written or IsArcEx error message box that could indicate the problem.

Please may you take a look at my changes and see if anything is incorrect? The old strings are commented out with //.

Thank you!

Code:
//function ISArcExAddDisks(Inputfile, Password: Widestring): boolean;
function ISArcExAddDisks(Inputfile, Password, OutputPath: Widestring): boolean;
  external 'ISArcExAddDisks@files:ISArcEx.dll stdcall';
//function ISArcExExtract(DiskNumber: Integer; OutputPath, CfgFile, WorkPath: Widestring): boolean;
function ISArcExExtract(DiskNumber: Integer; CfgFile, WorkPath: Widestring): boolean;
  external 'ISArcExExtract@files:ISArcEx.dll stdcall';
Code:
    #ifdef Data1
      if FileExists(ExpandConstant('{src}\{#Data1}')) then
      begin
        ISArcDiskAddingFalied:= ISArcExAddDisks(ExpandConstant('{src}\{#Data1}'), '{#DiskPassword}', ExpandConstant('{app}'));
        if ISArcDiskAddingFalied then break;
        ISArcExDiskCount:= ISArcExDiskCount + 1;
      end;
    #endif
Code:
for i:= 1 to ISArcExDiskCount do
        begin
          //ISArcExError := not ISArcExExtract(i, ExpandConstant('{app}\'), ExpandConstant('{tmp}\ARC.INI'), ExpandConstant('{app}'));
          ISArcExError := not ISArcExExtract(i, ExpandConstant('{tmp}\ARC.INI'), ExpandConstant('{app}'));
          if ISArcExError then break;
        end;

yes, there's something incorrect. see the hint below.

Code:
v0.4.0.0 (Old)  >>  ISArcDiskAddingFalied

v0.4.0.1 (New)  >>  ISArcDiskAddingSuccess
let me know if you need more help.



Quote:
Originally Posted by Masquerade View Post
There is no log written or IsArcEx error message box that could indicate the problem.

add this before the ISArcExInit. you'll see the error. (sorry, i put the error message in the wrong place in the script)

Code:
if ISArcExDiskCount = 0 then
   MsgBox('There is no any archive found for unpacking.', mbError, MB_OK);
Reply With Quote