View Single Post
  #14  
Old 12-12-2022, 18:36
Cesar82's Avatar
Cesar82 Cesar82 is offline
Registered User
 
Join Date: May 2011
Location: Brazil
Posts: 1,074
Thanks: 1,814
Thanked 2,304 Times in 787 Posts
Cesar82 is on a distinguished road
Quote:
Originally Posted by Gehrman View Post
Thank you Cesar82
The first bug is missing in "CIUv3 3.0.0.1.b9.u1 (2021.09.11)".

The second bug
It seems to be fixed with these changes.
Without using Diskspan, of course

Code:
function BrowseArcFile(const ArcFile, Disk: String; var SrcDir: String): String;
...........................
      IDCANCEL : begin
        Waiting := False;
        ISDoneCancel := 1;
        ISDoneError := True;
        ResumeProc;
        WizardForm.CancelButton.OnClick(nil);
      end;
Change to
Code:
      IDCANCEL : begin
        Waiting := False;
        ISDoneCancel := 1;
        ISDoneError := False;
        ResumeProc;
        ClickButton(@CancelBtnClick, nil);
      end;
It is better to be like ASIS so that the installation process can be canceled by clicking Cancel.
When I mentioned "any suggestions", I was referring to the behavior of the action when clicking the cancel button, or whether it should display the exit message.
You didn't necessarily need to have informed what changes need to be made.
But anyway, thank you very much!
I will review in a few days. I'm out of time at the moment.

Thanks for reporting so bugs.
Reply With Quote
The Following 2 Users Say Thank You to Cesar82 For This Useful Post:
amin fear (14-12-2022), Gehrman (13-12-2022)